6211 ДушечкинВА Лаб. 1 #324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxwrlld
reviewed
Dec 1, 2025
There was a problem hiding this comment.
Общие моменты:
- Отформатируйте. Для удобства используйте форматтер, например, Prettier
- Вынесите стили в отдельный CSS - файл
- Согласуйте имена с БЭМ. Напоминаю, что согласно БЭМ классы именуем по шаблону
имя-блока__имя-элемента_имя-модификатора. Подробнее тут и тут. Например,maze-cell->maze__cell, потому чтоmaze-cellэто блок, аmaze__cellэто элемент блокаmaze - Сдейлайте лабиринт более похожим на лабиринт. Сейчас больше похож на сетку. Для сокрытия границ используйте классы - модификаторы элемента
maze__cell. Например, класс, который отвечает за сокрытие верхней границы может называтьсяmaze__cell_open-top
mxwrlld
requested changes
Dec 18, 2025
mxwrlld
left a comment
mxwrlld
left a comment
There was a problem hiding this comment.
Напоминаю о необходимости внесения изменений!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6211 ДушечкинВА Лаб. 1.html